Hadley Wickham

Results 2588 comments of Hadley Wickham

That seems reasonable to me and I'm generally in favour of converting boolean arguments to enums.

Hmmm the renv + usethis issue is an example of more general problem, so we might need to solve that at a higher level. (No idea what that solution would...

I was thinking it would be a usethis function that generated the workflow yaml for you

Yeah, I think that's probably the right place for it to live. But this repo might still need to publish the components as individual yaml snippets. But let's wait on...

Hmmmm, I'd rather encourage people to put one alias on each line.

I _think_ this should be reasonably straightforward to implement — in `map_`, `map2_`, and `pmap_`, check `isTRUE(.progress)`. If it is replace with the call suggested by @gaborcsardi using the `.purrr_user_env`...

We're planning to submit testthat 3.3.0 to CRAN on Nov 10.

Yes, I think the problem lies with your `dbQuoteIdentifier()` method which should convert `dotted.name` to `` `dotted.name` ``. (I regret this decision to assume R quoting rules for table names,...

FYI I plan to submit on Monday Sept 16

IIRC `remotes` currently only affects the packages directly listed in `Imports` etc; not their dependencies. Maybe that's the fix I actually want? And maybe it would be useful to have...