Hadrien Mary

Results 313 comments of Hadrien Mary

Well after more investigations it looks like rdkit wasn't doing anything wrong but my custom context manager was not restoring the previous correct rdkit log state. I have fixed it...

I can confirm this bug with pandas 1.2.2 and the latest rdkit as of today.

I confirm @maclandrol fix works. That being said as soon as you create a new dataframe from the patched one, the patch is lost (for example `df.head()` won't show the...

Having to maintain those API layers could be quite time-consuming as they tend to change over time. Also by experience working with some of them, it can be tricky to...

Ok and sorry I think I misunderstood here xD I use list of dict to create df all the time and you can simply do `pd.DataFrame(list_of_dict)`. That being said I...

That would be nice to be able to link libzip to prevent errors such as `error while loading shared libraries: libzip.so.5: cannot open shared object file: No such file or...

Yes conda setup things specifically to be work on any CI used by conda, so such things happens often. I am not asking you to modify your CMake file here...

Thanks @hesther. Indeed psi4 is not on conda forge but it looks like it might come at some point: https://github.com/psi4/psi4/issues/2300 For now, I have just closed the feedstock PR but...

Nothing blocking for me. Thanks again.

In https://github.com/jkk/shinkgs/blob/23225ab59d8efcccfc264026dbe9bce4b8025c42/src/ui/board/BoardContainer.js#L33, maybe we should also create a `_setBoardHeight()` and use it instead of `_setBoardWidth()` when the screen is in landscape mode.