Markus D. Herrmann
Markus D. Herrmann
I would say that depends on the complexity of the task. If it's as easy as creating a `dict` object that maps private attribute to standard attribute than I think...
It seems that the task can get quite messy. Therefore, we may need to put some more thought into the design of the `highdicom.legacy` API, in case we would like...
> Also as a general rule I would vote against leaving any private tags in the normalized form of the instances. Are you arguing in favor of skipping all private...
To me there are two main motivations for legacy conversion: 1. representing a series of single-frame images as one `pydicom.Dataset` (such that the `pixel_data` property returns a 3D `numpy.ndarray`) for...
From an API perspective, do you think it would be sufficient to implement this in form of a simple `dict`, where keys would be private attributes and values would be...
Ok, maybe we can start by creating a document for flashing out the mapping and then delve into the implementation. It seems that the simple approach using a `dict` won't...
Thanks for your feedback @CPBridge. The use case I am trying to support is the following: We perform segmentation using more than one input image channels (grayscale images). These may...
@CPBridge we already perform several checks (see [here](https://github.com/herrmannlab/highdicom/blob/18fc8f454a307c33437c3bd00693b44426a24389/src/highdicom/seg/sop.py#L277-L286)) on `source_images`. We probably should add more attributes (Image Orientation, Pixel Spacing, etc.). We could also perform a frame-level comparison to ensure...
@CPBridge I added checks on `source_images` (15a71691a1622fc93814a88d998662d14093b2c0) and included references for all source image frames (ead8a30afd80f36bd41b44fdeaff23e50a7d509b). I also added a unit test to ensure that works properly (fc5b2d16785836e44d21338045dd3c72f9e60fb6).
As you pointed our earlier, the behavior is now different for single-frame and multi-frame images. I suggest we also support multiple series of single-frame image instances. To this end, I...