Markus D. Herrmann

Results 256 comments of Markus D. Herrmann

I'm using version **2.0.10**. I was in the meanwhile able to solve the `uwsgi_response_write_body_do()` problem. This was somehow related to my client side ([ngWebsocket](https://github.com/wilk/ng-websocket)) disconnecting. Why the client disconnected is...

> This looks good to me except one minor error I spotted. Though if I remember correctly, we were waiting on a decision about changes to the standard? We have...

These are all retired attributes containing `x` in the group or element part of the tag. pydicom stores those attributes not in the `pydicom._dicom_dict.DicomDictionary` but in a separate `pydicom._dicom_dict.RepeatersDictionary` and...

Yes, the attributes in Current Frame Functional Groups Module with group `0006` are skipped, since they are not part of the DICOM Dictionary. We could handle that special case separate...

> No, I don't need them. I just ran a test on all iods and modules to see if all modules are included. Ok. Thanks for the effort. I can...

@malaterre thanks for testing and for your feedback. @fedorov I was wondering whether we should create a smaller PR for a subset of the changes included to #34 to address...

@fedorov @malaterre by looking at the provided output, I am not sure what the problem is and whether it's a problem in highdicom or pydicom. @malaterre what happens when you...

@malaterre sorry for my delayed reply. We are currently focusing on the decoding API and will get back to legacy conversion once https://github.com/MGHComputationalPathology/highdicom/pull/93 is completed. Please note that with the...

We may want to define a separate Instance Segmentation IOD and implement it as a separate `highdicom.seg.InstanceSegmentation` class.

@seandoyle that's already underway with #69 (see [highdicom.sr.ImageLibraryEntry](https://github.com/MGHComputationalPathology/highdicom/blob/0be93c3a7889177b75bd98f701dee07b59625060/src/highdicom/sr/templates.py#L3296-L3431)). Note that I did not implement the modality-specific templates, but instead enable the caller to add the content items via the `descriptors`...