Markus D. Herrmann

Results 256 comments of Markus D. Herrmann

> Does this need to be a class in a new module? I was thinking of adding it as a function to the pixel utilities instead: I would prefer a...

> > For multi-frame images with a large number of frames, we don't want to build the transform object over and over again for every frame. > > I did...

Thanks for your feedback @scaramallion. We are using this abstraction very frequently in *highdicom* and I don't consider casting or ignoring viable options. The cast is quite ugly and really...

We learned that not only code meanings, but also code values may be subject to change. DICOM defers to the individual coding schemes on how codes are maintained. SNOMED sometimes...

I would suggest the following algorithm for updating: 1. Update `concepts` map in [pydicom.sr._concepts_dict](https://raw.githubusercontent.com/pydicom/pydicom/16896e244bd89a6978afda33cb7be8c0f7f51f8d/pydicom/sr/_concepts_dict.py), including codes from [Table J-1](http://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_J.html#table_J-1) using SCT codes as keys 2. Parse [Table O-1](http://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_O.html#table_O-1) and extract...

cc'ing @dclunie who pointed out Table J-1 and helped clarify questions regarding retired codes

>> 3. Look up concept in concepts map using SCT code as key. Use meaning specified in the looked up value to construct attribute name for codes.SCT > This sounds...

@mshunshin The value of the Basic Offset Table item can be used to determine the frame boundaries within the Pixel Data element value (see PR #534). The item value is...

> We should try to use an existing DICOM library if possible, rather than hand-parsing the DICOM container. There appear to be reasonable libraries in C++ ([DCMTK](http://dicom.offis.de/dcmtk.php.en) and [GDCM](http://gdcm.sourceforge.net/wiki/index.php/Main_Page)), but...

@bgilbert thanks for looking into it! It would be great if this format variant would be supported.