Markus D. Herrmann

Results 256 comments of Markus D. Herrmann

@darcymason are there any outstanding TODOs preventing this PR from being merged and released?

@scaramallion what are your thoughts?

@scaramallion I was wondering whether you had a chance to take a look. Please let me know if you have any questions or comments. It would be great if we...

@darcymason @scaramallion this is currently blocking a feature I would like to add to the [dicomweb-client](https://github.com/MGHComputationalPathology/dicomweb-client) library. The library already depends on pydicom and I don't want to introduce a...

Thanks for your review and feedback @darcymason! > I do think we need some more discussion of a frames() method for Dataset. Personally, I would not add more methods to...

> I'm busy through the weekend, but I'll try to think this over some more and make a decision next week. Thanks @darcymason. Much appreciated! > Actually, reading from a...

@darcymason @scaramallion is this something you still think would be useful to add to pydicom?

I would consider this issue related to #533 rather than a duplicate. This issue provides a specific suggestion for refactoring the existing pixel data handlers. I would avoid `decode_frame(ds: Dataset,...

> the function signature would have to change if more elements were required in the future That's a good point. As a compromise, could we agree on `decode_frame(value: bytes, metadata:...

I think we also need to pass `as_float`: ```python def decode_frame( value: bytes, metadata: Dataset, as_float: bool = False ) -> np.ndarray: """Decodes pixel data of an individual frame. Parameters...