Markus D. Herrmann
Markus D. Herrmann
> Do you expect multiple multi-frame source instances to come from the same series or different series? I would expect them to come from different series (the whole point of...
Thanks @afshinmessiah! I had a quick look and will review more carefully before we meet. In the meantime, as a first step I would suggest you look into the [coding...
@afshinmessiah please fix typing errors locally before pushing to avoid test pipeline failures such as this one https://travis-ci.com/github/MGHComputationalPathology/highdicom/jobs/430572557
@CPBridge @afshinmessiah @fedorov I would still prefer the constructor to just accept `Sequence[pydicom.dataset.Dataset]` and avoid introducing a new type. Conceptually, these classes convert a list (not set!) of single-frame image...
Thanks @dclunie for the additional information and background. Within the *highdicom* library we generally refer to a "frame" as an Item of an encapsulated Pixel Data element of an Image...
> A "sorted set" is still a "set", not a "list". Python doesn't have an ordered set and the interface of the built-in set differs significantly from that of a...
> Afshin was using those terms since he did not want to change the conventions used in Pixelmed. But I don't think this is worth an argument - can you...
In that case, I would prefer the function to have the following interface: ```python def group_per_frame_and_shared_attributes( instances: Sequence[Dataset] ) -> Tuple[Set[str], Set[str]]: """Assign attributes to per-frame or shared functional groups....
> I suggest we settle for the current FrameSet and FrameSetCollection classes since they are optional and users don't have to use them. I the future versions you can refactor...
> Is it possible to show all the 3 structures in a single frame? I am not sure I understand your question correctly. By "structures" do you mean "segments"? The...