Herman Jensen

Results 30 comments of Herman Jensen

I don't know if this is related, but our tests also recently started stopping running because of this error. .gitlab-ci.yml ```yaml test: image: cypress/base:16.13.2 stage: test before_script: - npm ci...

Codesandbox demo: https://codesandbox.io/s/swr-basic-forked-ogpwsw?file=/src/App.js

Added some tests. Didn't test for `error` yet, as I'm not sure if it should throw at all if just reading errors, as it already does when reading `data`. >...

Suspense would still need to be explicitly enabled in the options. This PR only changes when it's thrown, if the option is enabled.

Yep, I agree having a `read` function returned would be more explicit and probably self-documenting. I wanted to explore this option as the properties returned from useSWR already are getter...

Alternatively, if changing the API of `AddDownstreamWebApi` isn't desirable, I could just drop it. [Multiple calls to `AddHttpClient` with the same client name applies all options to the same client.](https://stackoverflow.com/questions/68122090/do-repeated-calls-to-addhttpclient-overwrite-each-other)...

I didn't think of that, looks like a good solution/workaround in scenarios where one policy is enough. In my case I call multiple downstream APIs, each with different needs, so...