AkiraFukushima
AkiraFukushima
/remove-stale
Can you please add a test to check the job is deleted?
I forgot that feature......, does the previous version have a context menu?
Hmm... `ecs-goploy` does not change `linuxParameters` in current task definition. Probably AWS API updates the section to default value when create a new task definition. So we have to override...
Please show me your mock file. And did you replace `electron` module with the mock file?
It seems correct... Could you run the jest example code in your machine? https://github.com/h3poteto/electron-mock-ipc/tree/master/example/jest
If you provide the tag in your log, it is outputted. For example: ```ruby logger.info({ msg: "foo", request_id: "" }) #=> {"level": "info", "timestamp": "2018-12-26T00:26:18", "environment": "development", "msg": "foo", "request_id":...
Thank you for your contribution. Your changes are good. But I think that it's better to show not only `message`, but also `cause`, `stacktrace` or other `StandardError` properties. What dou...
> but webhooks don't need that level of certificate. They just need to have their caBundle put into the MutatingWebhookConfiguration resource. I agree. I think it's good to support cert-manager...
> With this patch the CSRs for the pod-identity-webhook are now created (where as before they failed to be created at all). However when you go to approve them they...