Greg Ziółkowski

Results 292 comments of Greg Ziółkowski

Landed the alternative patch with https://core.trac.wordpress.org/changeset/59081. Thank you for all the help.

> Then we look at a following PR that supports "workspace:" for the other package managers ("yarn" and "pnpm"). > > Is this idea too "legacy"? I'm happy to move...

Great idea 👍🏻

What benefits do we expect from these changes that justify updating the entire codebase and documentation to use React directly?

In the `edit` implementation, you always need a block wrapper that receives the props that control block selection, block toolbar, etc. So in the example above, there should be `useBlockProps`...

It might be possible to refactor `RawHTML` to support the use case explained in the editing context, but that would require some operations to overcome React's limitation where you can't...

@mukeshpanchal27, are you talking about the following line when considering changes to the context? https://github.com/WordPress/wordpress-develop/blob/a78540b0881a195ec8488bb6bdf878114d75f8b8/src/wp-includes/class-wp-block.php#L496-L497 --- What we miss is that the context is set only for the top-level block...

I did a quick proof of concept, and it passed the newly added test, but there are some changes in two other tests that I need to investigate. The diff:...

> I wanted to offer another idea, similar to one mentioned in that same Trac comment, which is to use the filtered data to make a new WP_Block instance with...

> In terms of backwards compatibility, there are still risks, but I think there might be fewer. As far as I can tell, the only developer assumption that would be...