Greg Ziółkowski

Results 292 comments of Greg Ziółkowski

https://github.com/WordPress/gutenberg/pull/65151 landed this week and contains a new public API 🎉As it's going to be included in WordPress 6.7, it will need an accompanying dev note (added label) and documentation...

[WordPress 6.7 “Rollins”](https://wordpress.org/news/2024/11/rollins/), which contains all the finished work, was released last week. The work for unfinished but still applicable tasks will continue in the new iteration issue created in...

https://jestjs.io/docs/configuration#testenvironment-string Have you tried changing the test env for these test files in the package? That would be the correct environment anyway there. A code comment at the top of...

I mostly skimmed the changes applied and it all looks like everything is finally on the right track. The most important part is that linting passes! Excellent work 👏🏻

I added missing labels to PR, and restarted one of the CI jobs with e2e tests. CI should become green after they finish 🎉 Excellent job taking it that far....

When going through open PRs and issues, I noticed that this PR should also fix: - https://github.com/WordPress/gutenberg/issues/54127

My testing results from local copy. - `npm install` locally doesn't apply changes ✅ - `npm run lint:css` passes ✅ - Stylistic modification get detected by `npm run lint:css`, example:...

I published all the updates included in this PR with the `@next` dist-tag to npm. You can test it in your projects with: `npm install @wordpress/stylelint-config@next --save-dev` See https://www.npmjs.com/package/@wordpress/stylelint-config/v/23.0.1-next.5368f64a9.0. We...

> @gziolo The [@next](https://www.npmjs.com/package/@wordpress/stylelint-config/v/23.0.1-next.5368f64a9.0) package doesn't include the [scss-stylistic.js](https://github.com/mikeybinns/gutenberg/blob/754139f9a3c88aaed63af9f7d4f35dece9bdf39e/packages/stylelint-config/scss-stylistic.js) or [stylistic.js](https://github.com/mikeybinns/gutenberg/blob/754139f9a3c88aaed63af9f7d4f35dece9bdf39e/packages/stylelint-config/stylistic.js) files so when using the instructions to add: Thank you for testing. Great catch, I can confirm that when...

Yes, new PR is the way to go. Reviewing 👍🏻