Gyuho Lee

Results 43 comments of Gyuho Lee

Could you send a PR to implement this? Thanks!

Sorry for late response. Contribution is always welcome! Do you want to implement it? Thanks.

This makes collecting disk metrics much more complicated, since data from separate disks need to be aggregated for comparison. This might make sense if we only test Zookeeper.

@heyitsanthony How about removing `Release` completely, since terms have been already evaluated by the time `Acquire` returns? Is there any other case that I am missing? Before ```go raftDropHeartbeatLabel: /*...

@gap892003 As @heyitsanthony said: > The bindings should already be removed on disable when the .fail.go files are removed I think `gofail` should not rely on other tools. Easiest workaround...

@ptabor This looks great. Regarding > --experimental-enable-v2v3= promoted to --enable-v2v3=... or deprecated as we discussed, let's mark it as deprecated for 3.5 and remove for 3.6. Then, there's no need...

> I am not sure if we are still running the failure injection tests. We do run functional tests with failure injection in the CI but haven't implemented member add/remove...

I am seeing some other issues with gRPC proxy now. Will try to track down on this.

Sorry we just resolved other outstanding client issues that might be related. We still have a few more issues with client. Once we resolve them we will look into this.

@nolouch How often do you see this? Can you help reproduce with current master?