Tomáš Hromada
Tomáš Hromada
@bikeshedder Thanks a lot for opening the issue! My two cents (from a Rust beginner :)): I don't see the added value of Into/From traits for Config Pool; it seems...
@nickelser Yes! Thank you for taking the time to review this. I'll start by saying we're happily using this patch in production for more than a year (original PR: https://github.com/nickelser/zhong/pull/34,...
I see the tests failed; it seems this was caused by a comparison operator change affecting specific edge cases. @nickelser I can easily ‘fix’ the tests but that would change...
Interesting! I’m glad there’s a way for it to work in its current state, but I feel like sharing (writable) caches between PRs would also be nice. Are you thinking...
I want to confirm that adding the cache persist to `master push` indeed gives pull request access to the same cache. This is the workflow I used (filename `cache_persist.yml`): ```yml...
@YashMathur I wouldn’t say copy, really - the `push if: master` workflow is simply using the same cache as the pull request ones from feature branches, and in so making...
@YashMathur Yes, that’s exactly right. This may be obvious but if the cache doesn’t change often, all workflows are fast (PR workflows read the master cache, and the master push...
I don't think this issue is solved yet... but since GitHub has a way of approving running checks for external PRs, there may be a possibility to condition access to...
I'm looking into implementing this, since some of our PRs get very polluted and messy. I only checked GitHub API, but it seems that comments that are outdated are easily...
I'm looking into implementing this, since some of our PRs get very polluted and messy. I only checked GitHub API, but it seems that comments that are outdated are easily...