gwalck

Results 10 comments of gwalck

@bmagyar did you forget to move my post ?

Okay for the `set_nanosec` and maybe for the getting rid of the `state_msgs` when possible in the tests. The rest has more consequences I would prefer to get more control...

@christophfroehlich thanks for looking at my description. I used the wrong term, I did not mean controller activated (because I did not look at the states and output at activation,...

> > * only one test (state_consistency test) really tests the `state_msg` has expected values, other test seem to use it to read the internal state/last state. > > That...

I did it partially already, just need more time that I don't have before tonight at best.

@christophfroehlich Thanks for the time investigating and discussing. You are right I over simplified the problem of tracking error and P/ PI to the academic typical example I remembered. I...

I tried to use `PIDControllers` as following controller of a modified `DiffDrive` (to enable to send commands to an exported interface of the PID controller) in a gazebo classic environment....

@destogl thanks for the fix, but I still wonder what is the correct procedure in on_activate. Should the controller initialize the command to the current state (and ignore any unset...

First thanks for this PR. I am discussing the concept, not the implementation. so basically it goes from 3 long lines with direct result above prompt ``` myname@mymachine:[myworkspace]lastfolderofPWD$ ls CMakeLists.txt...

dear @Nils-ChristianIseke , thanks for the issue report. Did you try this script in a workspace created by RosTeamWorkspace scripts or in a standard ROS 2 workspace ?