Georg von Kries

Results 6 comments of Georg von Kries

What is this one holding back? It would be super useful 😊

This line also looks very suspicious, the created scope is never used: https://github.com/OrchardCMS/OrchardCore/blob/a27a75eaa9fbd9e193569a42d4cdab9fcd28903e/src/OrchardCore/OrchardCore/Shell/Builders/Extensions/ServiceProviderExtensions.cs#L112

Because I was working on the shell container factory recently, I took a quick look. If I understand this code correctly, it is an optimization if there is a single...

> Could you demo this at the next meeting to gather feedback, please? https://orchardcore.net/meeting, every Tuesday at 12pm PT. I try to attend next week or the following.

The scenario was to workaround #2268 and I was just expecting the tenant activated event to be raised after the pipeline has been build, similar to what the IApplicationLifetime is...

This seems to be outdated.