Gunter Van de velde
Gunter Van de velde
I have some comments on the Flex-algo PR. The proposal as it is, use some assumptions and observations for improving the PR. - Important to realize is that flex-algo is...
Hi Vivek, Thanks to consider my feedback. Please find delayed feedback caused by my PTO. > > I have some comments on the Flex-algo PR. The proposal as it is,...
> > I now updated to just include the 'flags-tlv' boolean that you suggested earlier to keep it simple. If there is a need in the future, we can add...
Hi @vivek-ilangovan Can this proposal be progressed? There are some checks not successful. Maybe the pyang tree's can be updated to reflect your latest code edits? I had a quick...
@vivek-ilangovan Many thanks. > I have added the participate bool. Both advertise and participate set a false does not make sense here but I couldn't think of a better way...
@vivek-ilangovan > Is it ok to retain it this way and SROS can probably fetch the algorithm from the `flex-algorithm` config and use it IS-IS? It is different hierarchy structure...
@vivek-ilangovan > > I am assuming SROS should then save the name to flex-algo-id map i.e. "My128"->128 when the "flex-algorithms" config is pushed. And use the flex-algo-id 128 when the...
> Thank you @gvandeve for reviewing this! Can you approve this review or do you know who can help in approving this.?Currently it is blocked with "Review required" Apologies for...
@dplore From Nokia perspective the proposed model reflects meaningful functionality documented by Flex-Algo [RFC9350](https://datatracker.ietf.org/doc/html/rfc9350). In addition the proposed model, while not fully aligned with Nokia yang model, is reasonably close...