Guy Bedford
Guy Bedford
@ejose19 I guess I'm still not clear on how the callback can be optional currently. But if the current eval doesn't return a value, then allowing the current eval to...
So because the invariant of per-line processing requires all eval implementations to conform, there's no middle ground here on creating a backwards compatible subset, got it. In that case moving...
One other question - what will be the outcome for eval implementations that do not call the callback? Will it just stall?
@ejose19 another option could be to check the function length of the `eval` function to see if its length includes the callback argument position. If not included it could be...
Ok, thanks for hearing me out on these questions, agreed the major is best then with the callback being enforced.
The workaround I have found for the above is to explicitly add: ```js const binding = path.get(`body.${index}.declarations.0.id`); path.scope.registerBinding('exports', binding); ``` to the injection plugin in the first case to ensure...
Any update here at all?
@Himself65 sorry, but this package is only taking bug fixes, not feature additions at this point, due to backwards compatibility requirements.
> Sure that makes sense. Especially considering that exports is the newest standard and it is possible to specify browser condition inside of exports, my gut feeling is the exports...
@patdx thanks for putting together this clear test repo, that's certainly information for me. I've posted https://github.com/evanw/esbuild/issues/2593 for further discussion.