Guy Bedford

Results 1051 comments of Guy Bedford

@andreasgrimm the thing to separate is if this is Karma-jspm or just the dependencies themselves. One way to do this would be to create a single file, app.js containing all...

How is this coming? Do you still need me to look into anything here?

Did you try reading some of the suggestions in https://github.com/Workiva/karma-jspm/issues/24?

An alternative may be to try karma SystemJS - https://github.com/rolaveric/karma-systemjs.

@maxwellpeterson-wf hey, sure it should actually be possible to know the baseURL by: - Setting `client.jspm.baseURL = getJspmPackageJson(basePath).directories.baseURL || '.';` in https://github.com/Workiva/karma-jspm/blob/master/src/init.js#L76. - Then using `'base/' + karma.config.jspm.baseURL + '/'`...

Interesting point @aduh95, I also would have expected `--import` to only apply to the main user loader like `--require` does, rather than executing in both the loader context and the...

@ejose19 I'm not aware of any debug stream testing, but there might be some examples in the existing tests directory to be found. Alternatively setting up something custom could be...

@ejose19 if we're doing a major change here anyway, should we also support `eval` returning a Promise? Or is the callback definitely necessary to get the correct timings?

@ejose19 what I mean is branching the API on sync / async handling with: ```js eval: () => Promise | undefined ``` where the undefined case is treated as sync,...

Yes that seems like the sort of approach if you agree it could make sense. Would this also allow this PR to be done in a backwards compatible way perhaps?...