Gustavo Henrique Nihei

Results 11 comments of Gustavo Henrique Nihei

> File ./arch/risc-v/src/esp32c3/Kconfig Unhandled token: depends This error is related to this `comment` command: ```Kconfig comment "Selected ESP32-C3 chip without embedded Flash, an external Flash memory is required." depends on...

> Thanks. I didn't look at all of the of `depends on` in the file. When I new which one it was the fix was easy. We talked about this...

How about applying this change only to the `static inline` functions from header files and simply removing the `inline` keyword from functions defined in source/implementation files? Usually the compiler is...

> > How about applying this change only to the `static inline` functions from header files and simply removing the `inline` keyword from functions defined in source/implementation files? > >...

> In this initial change I start replacing `inline` with `inline_function` (that is currently a force inline actually) so now I'm thinking of: > > 1. Rework `inline_function` to be...

I agree that the model information may be useful, but is it correct to add it to geometry? It will be a bit strange for it to be there while...

Please, squash these two commits: https://github.com/apache/incubator-nuttx/pull/4129/commits/ea0ddd188e222dadcaa6e0860ad97ebf79656969 / https://github.com/apache/incubator-nuttx/pull/4129/commits/790639c769bf4fea1677e7bb16fb069b7a77fa22

Hi @tito97sp. Contributions are generally welcome, but in this case I would recommend against adding this kind of feature to the MCUboot Update Agent example. This application is designed as...

RTC Watchdog Timer has been implemented and validated on https://github.com/esp-rs/esp-hal/pull/134 and https://github.com/esp-rs/esp-hal/pull/139 for all currently supported chips. The RTC driver itself has been improved as part of those tasks, but...

> @gustavonihei I finally get the time to improve the patch as your suggestion, please take a look. Sorry for the delay, I didn't notice the first ping. So in...