Gus Heck

Results 21 comments of Gus Heck

@tflobbe Please review what I did to make enable the uploading of config sets within tests possible. When I tried to re-enable this test it was failing it was untrusted...

Yeah sorry haven't got back to this. Work is quite busy. my recollection is that my initial thought was that the concern raised is not actually a problem since no...

Just finding this now, sorry that I'm late to the party, I really think "String" should be a word used for things that involve encodings like UTF-8 etc. Could we...

had some boxes to setup and I patched this onto branch_9_2 to give it a whirl... First problem I had was that though the error message in the setup script...

Ok need to give it JAVA_HOME: ```` Environment=JAVA_HOME=/opt/java/zulu11.64.19-ca-jdk11.0.19-linux_x64/ ```` So the install script in general seems to need to be more respectful of JAVA_HOME... (and add it to the service...

Next thing I notice is that this is setting up a legacy/user-managed service. We should probably be defaulting to a cloud service? (certanly zookeeper existing beforehand is a pre-requisite, but...

The discussion on this is long, so maybe I've missed it, but the actual merged code has introduced the possibility (though I suspect it might never happen) of a non-numeric...

I guess the question is more a matter of how safe you think this change is... We all know that there are some flaky tests. The test doesn't sound related...

So code that does something with that maxScore value could hit null/undefined? That's sort of iffy for back compatibility... On Mon, Apr 22, 2024 at 4:51 PM David Smiley ***@***.***>...