Gurinder Singh
Gurinder Singh
@copilot Refactor the code inside the with_file_lock's closure inside project_is_created into two functions. First one called 'verify_new_project_creation` should contain the part of the code that creates the new project and...
@copilot fix failing code formatting checks
@copilot fix the clippy lint failure
> > @copilot fix the clippy lint failure > > I'm unable to run clippy in this Linux environment as it requires Windows-specific dependencies. Could you paste the specific clippy...
> @gurry did you test this on a release-plz branch to check that you see the `Skipping driver build due to SKIP_BUILD_IN_CARGO_WDK_NEW_TESTS environment` print? Yes, I opened two PRs, [one...
> > The changes look good to me. > > I think we should add an issue to the backlog to create a new pipeline or action for an extremely...
@wmmc88 and @krishnakumar4a4 Another review please. I have merged changes from main and resolved a few conflicts.
This will become possible if `cargo-wdk` supports specifying target through `config.toml`, which we are tracking in issue https://github.com/microsoft/windows-drivers-rs/issues/435. Different projects could then specify different targets in their `cargo.toml` and a...
> This will become possible if `cargo-wdk` supports specifying target through `config.toml`, which we are tracking in issue [#435](https://github.com/microsoft/windows-drivers-rs/issues/435). Different projects could then specify different targets in their `cargo.toml` and...
Thanks for the PR @tw4. Can you please also update the tests by adding this check for the `.git` folder: ```rust assert!(tmp_dir.join(&driver_name).join(".git").is_dir()); ``` right after this line: https://github.com/microsoft/windows-drivers-rs/blob/1716d4a5d34acc0fbb1e0a4effad57530aad4bae/crates/cargo-wdk/tests/new_command_test.rs#L147