Gurinder Singh
Gurinder Singh
As per our discussion, one solution may be to peek into the `members` section of the workspace-level `Cargo.toml` and locate member projects instead of blindly enumerating sub-dirs in the workspace.
@copilot This approach has the problem that the tests are ignored by default which means they will be skipped when someone runs cargo test locally. Can you flip the default...
@copilot What about the tests run by the `local-development-makefile.yaml` workflow which runs these tests through the `wdk-pre-commit-flow` cargo-make task?
@copilot We don't need the `is_release_pr` flag
@copilot can you explore the approach of conditionally applying `#[ignore]` attributes on these tests? The condition could be some some env variable or feature flag passed to the the `cargo...
@copilot Let's take approach 3 (env vars) but with a slight modification. When the env var is set skip only the build part of these tests. The part that creates...
@copilot I don't think we need to explicitly close `tmp_dir` in `create_and_build_new_driver_project`. It should be automatically closed. Remove it to reduce code duplicaiton.
@copilot the `project_is_created` function isn't pulling its weight any more. Inline it into all call sites
@copilot run `cargo +nightly fmt --all` and fix the failing formatting check
@copilot we have this clippy lint failure: this function has too many lines (101/100) --> crates\cargo-wdk\tests\new_command_test.rs:106:1 | 106 | fn create_and_build_new_driver_project(driver_type: &str) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further...