Markus Gritsch

Results 66 comments of Markus Gritsch

+1 for this one!

@jgoux Hello, a use case of this kind works, I am also experimenting with the library specifically the implementation of a Navigation Component that uses Framer Motion for animation. Since...

I did upgrade to 1.0.0-canary.2 in the afternoon, but the type Translate is not there, also useTranslation is not exported. I consume it through. ```import useTranslation from 'next-translate/useTranslation';```

Looking at the index.d.ts from the sources the Translate interface exists, but the build does not have it. I don`t know the internals how you build the deployment bundle, but...

I think the build is just fine. Translate interface for the t function does not exist anymore, instead it is either ``` t( i18nKey: string | TemplateStringsArray, query: TranslationQuery |...

For the useTranslation exposing through a named export I think you have to add useTranslate in the index.tsx file, next where you do https://github.com/vinissimus/next-translate/blob/72abc8be67f56cd6e98043c61ad2d7012e6f149d/src/index.tsx#L3 ``` import nextTranslate from './plugin' module.exports...

Reading the comment in index.js makes me thinking, haven`t heard this at all, global imports... Maybe something was misunderstood back then, but doing "named" exports allows "named" imports. This has...

I don't think I can list the pros and cons of Named Exports in detail myself. I have to admit that my arguments are only based on my experience. My...

Thats great! For the Translate type maybe you can reduce those three t functions to just one, with some arguments optional. If not maybe typescript unions and Intersection types help....

Hi thanks for adding this. I use the option to return objects quite frequently, same as the standard variant. Is it possible to change the Generic Typ a bit to...