Sounak Gupta comments

Results 6 comments of


                                            Sounak Gupta

File-mapped memory support in shared memory manager

Did anyone get a chance to review this PR ?

File-mapped memory support in shared memory manager

> I'm in the process of reviewing. I am curious that do we have to associate a path and a name with each file segment? Can we use only name...

File-mapped memory support in shared memory manager

> > Thanks for clarifying. Is it correct that in the future it will be possible for the same shmManager to mount different types of segments (tier 1 is file,...

File-mapped memory support in shared memory manager

> Hi! Thank you for making the change. We discussed internally on how we can bring FileShmSegment into cachelib and allow compatibility. We'd like to suggest the following change (your...

File-mapped memory support in shared memory manager

Closing this PR due to priority re-alignment. NUMA support for CXL is now the primary focus in memory-tiering.

[Upstream] Rolling Stats rebased against the upstream AC Stats branch

*[`cachelib/allocator/Cache.h` line 89 at r2](https://reviewable.io/reviews/intel/cachelib/47#-NKTOn_d1VgVoDjmIGGz:-NKqoPzn1ISPANeeO4qp:b-7ql1td) ([raw file](https://github.com/intel/cachelib/blob/f5145be0ccc4c6ad7d3f1cf7d2681bbb0719897d/cachelib/allocator/Cache.h#L89)):* Previously, igchor (Igor Chorążewicz) wrote… Is it needed? fixed