Ganesha Upadhyaya
Ganesha Upadhyaya
@kraikov Interesting. This should have worked correctly, as decoding is based on the event format specified in the abi. Let me take a look. Thanks.
@hmexx can you try catching error inside `.on("confirmation", ...` block? looks like sdk emits confirmation (`=false`) even for the failure case: https://github.com/harmony-one/sdk/blob/master/packages/harmony-transaction/src/transactionBase.ts#L191
> Afraid it didn't work. Exception from the SDK took down the process again: > > ```js > 11:20:07: Withdraw: send failure within Harmony, reverting balance for wallet 11949 >...
@vikramIde need more information. can you copy paste the error you are getting and output of `truffle version`?
@vikramIde try changing the line to `pragma solidity ^0.5.3` , it will allow any higher versions of 0.5.x too compile.
@vikramIde try using `Node v10` here is my `truffle version` ``` Truffle v5.0.38 (core: 5.0.38) Solidity v0.5.8 (solc-js) Node v10.17.0 Web3.js v1.2.1 ```
@rlan35 @LeoHChen @MaxMustermann2 could you guys help with review of this PR?
> Other optimization points: > > 1. In the current scheme, MMR can only prove block hashes. To prove a receipt, it also needs to provide the block header, then...
@rlan35 @LeoHChen could you review this PR? I still need to add some unit tests to MMR package. Will do that in a couple of days. Otherwise, the review can...
> Some questions other than the comment: > > 1. Is it true that each MMR file is mapped to one shard? > 2. I am not familiar with MMR...