Gunnar Morling

Clarify rounding semantics

1

See https://github.com/gunnarmorling/1brc/pull/5#discussion_r1440578784; CC @AlexanderYastrebov

Fix tests (ddimtirov)

1

Hey @ddimtirov, since your submission we've added a basic test suite for covering some corner cases (as we discussed already). One of the tests fails for your submission. Could you...

Provided folks stick to the requested convention and name their launch script after their user name, we should be able to run the _tests.sh_ script as part of PR builds...

Hey @kuduwa-keshavram, since your submission we've added a basic test suite for covering some corner cases (as we discussed already). One of the tests fails for your submission. Could you...

Specify how to set the JDK with SDKman in the launch scripts

1

Getting e.g. this one: ./calculate_average_ebarlas.sh: line 18: sdk: command not found I think it's because `sdk` is a function or something? If anyone has an idea of how to set...

Add test case for station name of length 100

1

As that's the maximum length defined in the rules.

Document steps for environment configuration

1

Hey @rschwietzke, would be nice to have it a text file in the repo, so as to have it reproduceable for everyone.

Tests fail or don't finish: twobiers

1

Hey @twobiers, could you please run ./test.sh twobiers and send a PR to make sure they pass and finish in a short time? We have added some tests to cover...

Hey @fatroom, could you please run `./test.sh fatroom` and send a PR to make sure they pass and finish in a short time? We have added some tests to cover...

Hey @moysesb, could you please run `./test.sh moysesb` and send a PR to make sure they pass and finish in a short time? We have added some tests to cover...