Gunnar Morling

Feedback for README.md of MapStruct

1

Hi, I just learned about this project/service -- it's a fantastic idea! If you have the time, we'd love to have your feedback on the README of MapStruct: https://github.com/mapstruct/mapstruct. We...

Clarify license of protobuf-converter

5

Hi, the root README file suggests that there should be a dedicated LICENSE file in each of the sub-modules of this repo, stating the license of this particular module. This...

Allow to distinguish between API and SPI

6

In libraries one usually has two kinds of contracts: - Things to be _invoked_ by client - Things to be _implemented_ by a client (often, that's more advanced use cases,...

kafka-connect-mongodb-1.2.0-jar-with-dependencies.jar contains superfluous dependencies

1

Hi @hpgrahsl, it appears as if the dependencies could be optimed a bit, as there are some Maven plug-in related things in there. This seems to be caused by this...

Update version to snapshot after release

2

As discussed in https://github.com/moditect/moditect/pull/153; // CC @aalmiray

E.g. see here: https://medium.com/azulsystems/using-jlink-to-build-java-runtimes-for-non-modular-applications-9568c5e70ef4 The list of JDK modules to include would have to be given explicitly.

Leveraging the [os-maven-plugin](https://github.com/trustin/os-maven-plugin), it should be possible to properly handle the Netty modules which have native dependencies, i.e. dependencies whose classifier is resolved based on properties set by this plug-in....