Adrien Guillo comments

Results 116 comments of


                                            Adrien Guillo

Publish our experimental build on a different image.

We no longer override the `latest` image for `qw-*` tags. I fixed it yesterday.

Publish our experimental build on a different image.

I think you meant different image, for instance `quickwit/quickwit-dev:fulmicoton-123`?

source: preserve Position arg in ObjectUriBatchReader

This is not the right fix. It's a bug in the checkpoint delta logic in the source. If you print the batch checkpoint deltas in that unit test, you will...

source: preserve Position arg in ObjectUriBatchReader

This is the right fix and we're not going to break anything. I will not merge this PR as is.

Refactor Source building

I was working around that code yesterday, and I'm leaning towards solution 1. `source_type()` does now return an enum. We can dispatch directly and statically in `load_source`. We can optionally...

Make RateLimit Clone (#794)

I don't think users should pay for a mutex if it's not necessary. Maybe we could introduce an `AtomicRate` that we can clone, then make RateLimit generic over a `RateImpl`...