Guillermo Echarri
Guillermo Echarri
Hi there! First time contributor here so sorry if I messed anything up. I see that I have some issues with "ci / prettier" and "UI Tests". Those seem to...
> First of all, thanks for controbuting. > > To me this looks like another tricky scenario that initially the _possibleOptionsChanged_ function in the brain service tried to solve. >...
> ... > We now have to options: > > 1. use your solution with the options observable and remove the possibleOptionsChanged, because it is not needed anymore. > 2....
I update the PR. The main changes are: - Now possibleOptionsChanged is no longer needed. I created an effect in the brn-select component that syncs the possibleOptions in the service...
Cleaned up according to the feedback :)
Updated to fix the minor comments
I'd also like to be able to add columns with @for I think I have an idea of how to implement it, I'll try to open a PR within a...