Guido Marucci Blas

Results 42 comments of Guido Marucci Blas
trafficstars

Hi! I'm seeing the same issue of WalletConnect opening the store instead of MetaMask but only when I triggered the message sign call. Here is a recording of the issue...

As @himanshuchawla009 mentioned by asking the user to click on a button to open the wallet I was able to workaround the issue and the app store no longer opens....

I am also seeing this behavior, if we do `carthage update SomeDependency` all the dependencies listed on `Cartfile.resolved` are fetched. Maybe this is expected behavior or requires a separate issue...

I'll look up on the `--no-use-binaries` issue tomorrow and let you know.

@mdiep After doing some digging I realized there is NO bug with the `--no-use-binaries` flag. It was actually a problem in one of our scripts that wraps Carthage. Sorry for...

@mdiep Regarding this particular issue. I think that the problem of fetching all dependencies even when you pass the list of dependencies to updates is related to this method https://github.com/Carthage/Carthage/blob/master/Source/CarthageKit/Project.swift#L655...

Yeah I imagine that could be the case. Any hints on how to solve this issue? Is there any way to reconstruct the dependency graph from a `Cartfile.resolved` file without...

@mdiep What about using this function to get the list of dependencies and their transitive dependencies to be fetched? https://github.com/Carthage/Carthage/blob/master/Source/CarthageKit/Resolver.swift#L38

Then collect the result from that method into an array of `Dependency` and pass those to https://github.com/Carthage/Carthage/blob/master/Source/CarthageKit/Project.swift#L660. Would that work?