Guillaume Thiolliere

Results 104 comments of Guillaume Thiolliere

> **Regarding your architectural concerns:** You mentioned mixing two different derive strategies (codec vs `*NoBound`) might be confusing and suggested three alternatives. I'd appreciate your guidance on which direction you'd...

Metadata v16 doesn't explicitly specify the transaction extensions used by signed extrinsics. Signed extrinsics don't support multiple versions of transaction extensions. Currently, it dispatches with version 0, and we can...

The difficult part is that the extrinsic will fail to dispatch. Also even bare extrinsics have some transaction extension like `CheckWeight`. One solution could be to require a benchmark for...

> > The difficult part is that the extrinsic will fail to dispatch. > > Also even bare extrinsics have some transaction extension like `CheckWeight`. > > I don't get...

/cmd prdoc --audience node_dev --audience node_operator

> After thinking about it some more, I am in favor of not overengineering this problem. @gui1117 To move this forward I propose to just check if the `ValidateStatement` runtime...

I forgot to include the host function, this may makes the implementation more difficult, I will see how to declare the host function conditionally.

I updated the implementation to enable the statement store if `ValidateStatement` runtime api is present in the best block when starting the node. But there was also 2 miss in...

zombie test added, this is ready for review, if we can have it in the next stable release (end of this month) that would be awesome.