Guillaume Thiolliere

Results 104 comments of Guillaume Thiolliere

> Dont know why the linux tests fails, but could be legit. my own test was failing, my bad. fixed in https://github.com/paritytech/polkadot-sdk/pull/5355/commits/5ace71d4f1ee7a5cf18a54179824a26ec3a2b8ee

/cmd prdoc --audience runtime_dev

test are failing because import is missing. also it needs a prdoc.

you can do a prdoc file like this: ``` title: 'feat: add hooks for utility batch' doc: - audience: Runtime Dev description: TODO crates: - name: pallet-utility bump: major -...

but what is the plan forward? Is it unreasonable to have something working and upstream in polkadot-sdk or do you suggest to have a fork to maintain forever. Also is...

From what I see the main change is in sc-network, sc-client-api and sc-service The whole point seems to get a richer service for IPFS, if we can do it as...

For information there I had 2 PR to upgrade usage to authorize call: * https://github.com/paritytech/polkadot-sdk/pull/6325 * https://github.com/paritytech/polkadot-sdk/pull/6326 I also think it is actually somewhat a breaking change. Even if the...

> Agreed, these 2 PR's you mentioned complement this one. What is blocking them? Because I think it is unnecessary breaking change. In general I don't think we should deprecate...

> I agree that the new extension mechanism currently lacks documentation, and requiring runtime developers to explicitly include `frame_system::AuthorizeCall` is not ideal. It might make sense to enable this extension...

Looks good to me, but zombienet tests are failing somehow.