Gustavo Giserman

Results 16 comments of Gustavo Giserman

+1 Play/Pause from my keyboard is actually playing or pausing playback but `onplay`/`onpause` callbacks are not fired, so my UI doesn't reflect the state change. I couldn't find any documentation...

> Ok, thanks for reporting, I will fix it No rush at all! Thanks 😄

@havenchyk any news on this one? I just found this project and it seemed like a lifesaver for a quick drop-in replacement of our current date range picker, but then...

> Hi @gugiserman . Thanks for you PR, but due to browser restrictions simply adding `async` is not as easy. I need to check whether webpack + babel properly transforms...

I see. If the transform works well we could deprecate the event, yeah. I still didn't have the time to properly address your concerns about the code, I also feel...

> I'm not familiar with isometric games, is it common to make sprites directly in isometric format, or is it common to make sprites in normal format, but use skew...

@slmjkdbtl any idea what could have happened here? I simply rebased the branch and adjusted `getPos()` of `isometricLevel` to match `level`'s interface. ![image](https://user-images.githubusercontent.com/4623123/143530095-0c16cad7-c3f8-492a-90a8-7045f3d3670c.png) FYI I'm dismissing your approval and requesting...

> Weird, maybe the break is introduced by [72b59c8](https://github.com/replit/kaboom/commit/72b59c8ce50c7369d9ef52d211901fe48e299ff6) which does some refactoring on how game objects work, can you try if reverting to rebase on the previous commit [03c23a2](https://github.com/replit/kaboom/commit/03c23a292a8792be6e238c37d77b731e481486b2)...

> Sorry for the delay. The issue should be fixed in #468, if it does feel free to merge anytime Thanks! But it's still pending your review before I can...

@slmjkdbtl hello man, I just ran a very difficult rebase of my branch and was checking if everything is good. Can you help me out here if there's still any...