Guillaume Valadon
Guillaume Valadon
Thanks for your interest in Scapy. What will be the benefit of such changes?
I am not convinced by this proposal. The readability gain is likely marginal. Do you know if this could have a positive impact on performances ?
It this compatible with type hints? https://docs.python.org/3/library/typing.html I had a look at static typing for Scapy, and it could helps us catch some bugs and improve the API consistency.
There is a type hints syntax that works with Python2: https://www.python.org/dev/peps/pep-0484/#suggested-syntax-for-python-2-7-and-straddling-code It works fine with our code base =)
Awesome! I tried pyannotate but I did not find time to do more than a quick PoC. I remind that mypy outputs a lot of errors that need to be...
@akshaycbor these errors are related to the activation of checks concerning `scapy/utils.py`.
I have been reading the RFC4366 and I think that current Scapy behavior is correct. I believe that the best solution is to use `TLS_Ext_Unknown(type=5, len=0)` to generate such extension....
If I understand correctly, you sniffed the Server Hello message, dissected it with Scapy, then tried to build it again? The real extension was 4 bytes, but Scapy returned 5....
Thanks for the report. I will try to find a correct fix. As of today, Scapy encodes the Certificate Status Request on 5 bytes. It still did not find an...
I had a look at the PR. It seems that some changes are only cosmetic. Could you revert them?