Guido Trentalancia
Guido Trentalancia
Should be fixed by: https://github.com/gtrentalancia/oregano/commit/29e08d0db1b041fae8954977ccefa5db4a4331d7
Changing the grid size is not recommended I suppose, as the parts won't be aligned properly otherwise. Consider the grid is never printed out when you print the schematic, so...
I suppose this issue has been closed with my commit: https://github.com/gtrentalancia/oregano/commit/8dd76c5c89becdd3340e364dd6f9f222e4552f1a and your subsequent merge: https://github.com/drahnr/oregano/commit/4e8c529f22563191978db36bfff654282896ab81 Please let me know if there is anything else I can do. Also, for...
The two functions oregano_error() and oregano_warning() should only run in the main thread. As simple as that...
Should hopefully be fixed here: https://github.com/gtrentalancia/oregano/commit/27f932e900740550432e285cacc579f9ca2ac369
Yes, you are right, the patch can be improved by adding the selinux=0 option to disable SELinux. Thanks for pointing that out ! I can do that, as I believe...
I have now submitted a revised and improved patch which should fix all the remaining issue. Can you please submit an updated review ?
Can you please explain a bit more detailedly what problem are you expecting to happen if the existing selinux-loadpolicy module is removed ? I am happy to leave the existing...
Should be good to go now !
I have double-checked and thought again about the backwards-compatibility issue that you raised with removing the existing _selinux-loadpolicy_ module issue. To the best of my knowledge and understanding there is...