Kostis Karantias

Results 20 comments of Kostis Karantias

Gives me an idea. http://4.bp.blogspot.com/-VQxu0jhRbqU/TcSf-REO-BI/AAAAAAAAAA0/gC4JkR2v-6A/s1600/paperclip.jpg

Let's not go crazy with style changes yet, these will only complicate and delay the reviewing process. Also let's do the work of converting to TypeScript while keeping the .js...

Also I'm not seeing changes to `package.json` for making this publishable. I'm guessing we need to add a build/prepare hook and somehow include the compiled JS and type definitions. I...

This is also a good opportunity to get rid of babel as a dependency. I think we're using the polyfill for some Array prototype function, but we can probably rely...

I'm seeing lots of `any` on the types. Not filling in all the types is OK but prefer to not type the thing at all instead of using `any`, as...

I got rid of the babel compiler and polyfill and use the TS compiler myself as of https://github.com/gtklocker/bittrex-orderbook/commit/1823ba8035cebd7bdf870016b5d40630225e2b99

@themicp definitelytyped is for when you type a JS package you don't control. Seeing as this will be in Typescript we'll provide our type definitions in-package. I think it may...

@pkakelas please look at the previous comments before doing more work and rebase

Hi, thanks for trying out `bittrex-orderbook`! I'm afraid you're right, there's currently no way to disconnect. Without being certain I think `bit.conn.client.end()` (assuming `bit` is your `BittrexOrderbook` object) will probably...

@pravi it may be useful and flexible, I don't necessarily disagree. I haven't written or used this software for long enough to be the judge of that. But having it...