gtk-rs-core

gtk-rs-core copied to clipboard

[FEATURE REQUEST] `use_cloned!` macro

4

I propose adding a `use_cloned!` macro with the following semantics: ```rust button.connect_clicked(use_cloned![move |_btn| { weak!(label, panic).set_label("clicked the button"); strong!(label2).set_label("I'm strong"); }]); ``` **Benefits:** - **Formatting from rustfmt** I found out...

ranfdev

glib: Panic in Object::new() and related functions and add try_new()

23

Fixes https://github.com/gtk-rs/gtk-rs-core/issues/766 ---- Depends on https://github.com/gtk-rs/gir/pull/1380

sdroege

`glib::Object::new()` should panic on failure and new `try_new()` variant needed

5

This would be consistent with how `set_property()` and similar API work nowadays. 99% of all cases are just unwrapping on failure anyway as it's a programmer error and not a...

sdroege

It's redundant because you can always get `Self::Type` via `self.instance()`. It would reduce quite a bit of noise and also reduces some confusion, but OTOH makes it less visible how...

sdroege

Convenient for `unwrap_or_default()`

sophie-h

This will probably need changes in gtk/gstreamer too

sdroege

`std` doesn't have almost anything of that, and the crate implementing all that seems is using icu, which is huge and annoying to build. The utf8 APIs should probably take...

sdroege

ParamSpecBuilder functions named inconsistently

5

It's `.minimum()` and `.maximum()` but `.default_value()` and not `.min_value()`/`.max_value()` and also not `.default()`. It's also `.read_only()` but `.readwrite()`, notice inconsistency in underscore usage. cc @bilelmoussaoui

vivia

`Dowgrade/Upgrade` not ususable in traits

2

```rust trait Mytrait: Downgrade { fn mushroom(&self) { let weak = self.downgrade(); let this = weak.upgrade().unwrap(); this.snake(); } fn snake(&self) {} } ``` fails with: ``` error[E0599]: no method named...

gdesmott

Depends on https://github.com/gtk-rs/gir/pull/1551 Fixes https://github.com/gtk-rs/gtk-rs-core/issues/1257

bilelmoussaoui