gswangg
gswangg
Cool. I'm investigating the split_reduceop bounty as my primary focus right now (not ready for a draft PR yet), but I'll work on this test migration in batches sporadically, if...
test_linearizer has > 20 tests that use LazyOp. to keep each PR reasonably sized, I'm thinking of breaking the port of this file into smaller batches. However, if its preferable...
Note that the bug flagged by claude code as duplicate is related to the proposed 'possible' solution to my specific problem (set theme from settings.json), but not the root cause...
+1 for supporting more sophisticated session checkpointing/forking. the poor man's version of this that you can do in the latest version is, in the session that contains your desired context,...
@Qazalin regarding > Should also fix DEFINE_ACC's extra type_verify assert. I was looking at [you convo with geohot regarding this](https://discord.com/channels/1068976834382925865/1068982781490757652/1254860202566488165 ) but I wasn't able to come to a firm...
I'm diff'ing process replay runs + ASSERT_PROCESS_REPLAY=0 with and without commit 61f9453 and I'm seeing different kernels getting generated. So looks like I've got more work to do.
Note: I added the GEP-VECTORIZE-CONST rule because I was getting some strange UOps sequences without it after updating UOps.const(). Attaching GRAPHUOPS=1 images with (gg.uops.svg) and without the rule (bg.uops.svg) --...
> @greg-niemeyer when I was playing around with the code, when rendering DEFINE_ACC, it calls render_const with vectorized dtypes sometimes. That might be part of the assert fail. right, I'm...
Had to add [the render_cast for !(int, bool, float)](https://github.com/tinygrad/tinygrad/pull/5322/commits/499f7e85ab764e90dd7a000ce5ed0b7d14393c52) back -- there are longs, shorts, etc. that need their long-form cast rendered.
I'm not super happy with [DEFINE_ACC implicitly vectorizing CONST in cstyle](https://github.com/tinygrad/tinygrad/pull/5322/files#diff-9694d15708a36a57a7e1485db60b1b4b1d2fc1e7278bc87127a73efd0bfa7dc0R171-R173). Should I update DEFINE_ACC in UOps such that its src is VECTORIZE or CONST, consistent with its dtype?