gsingh93

Sorry for the delay in reviewing, I just got around to it. Everything looks good, most of my comments are nits and questions. Did you test this with the servers/clients...

I talked to @reem on IRC a few weeks ago. His fork at https://github.com/terminalcloud/thrift is much farther ahead than this repo, and I think it'd be a lot of effort...

Thinking about this more, this would mean multiple instances of `Protocol` would own the same transport. If we did this, we'd have to use an `Rc` or an `Arc`.

This would probably be better in the Rnext milestone, right?

I haven't used this, but we might be able to replace the `buf_stream` feature with [this crate](https://crates.io/crates/bufstream). And if we remove the unstable features, we might as well move to...

Personally I've found my most used channels the stable and nightly channel. I haven't used the beta at all. The majority of the time stable works great. Unstable features are...

Now that #26 is closed, we should be clear what is left to implement here (if anything).

I'm looking at the `render_rs_type` function and it looks like it handles all types.

@radekg Are you still working on this? The other issues that need to be done before submitting this to the mainline are almost complete, so I just wanted an update...

Thrift seems to have its own `.travis.yml` file. If we just enable the builds in travis, should that cover it? Or if you want to have a simpler travis file...