Gunar Schorcht

Results 110 comments of Gunar Schorcht

@maribu You might have a look on the `ads101x` test application in PR #10619.

@maribu Maybe you missed my comment https://github.com/RIOT-OS/RIOT/pull/13247#discussion_r379307616 between all the others. The following part still needs to be removed. It's now in `adc_ng_global.h`. https://github.com/RIOT-OS/RIOT/blob/ff157d74d0bfb7a77d7026349b23e6a5a281f860/drivers/adc_ng/include/adc_ng_internal.h#L68-L78

@maribu There is a further general question. https://github.com/RIOT-OS/RIOT/blob/ff157d74d0bfb7a77d7026349b23e6a5a281f860/drivers/include/adc_ng.h#L261-L262 [Update]~This does not apply to ADS1x1x. These ADCs also allow negative values for single-ended inputs.~ Negative values are only possible for differential...

> Hmm, that's odd. A 12 bit signed integer should have the range -2048 ... 2047. A 16 bit integer indeed should have range of -32768 ... 32767. Sorry, my...

@maribu Thanks for your offer to review the driver. We should wait some more time for an answer from @basilfx. Once he has answered we can decide whether to redesign...

> `esp_wifi` and `atwinc15x0` are handled by `gnrc_netif_ethernet.c` I assume? Sorry, after a couple of months with other tasks I am no longer up to date, but I guess you...

> @gschorcht Could you run your `urlcheck.sh` through the [shellcheck](https://github.com/koalaman/shellcheck) tool? There are a few quoting issues with variables pointed out by shellcheck. I will do. Thanks for the hint.

One problem I have already noticed is that the shell script requires that a URL is always defined in one line. To be able to handle line breaks in URLs,...

> From my understanding of the RIOT-OS's WiFi Network Interface for ESP32, it is > > * only possible to specify the mode (Station or SoftAP) in the makefile before...