Grzegorz Orczykowski

Results 80 comments of Grzegorz Orczykowski

I think if there is null, empty or invalid hash (without prefix) we should ignore such a file. It's not our fault so there is no reason to be overprotective.

> if we should refuse to download the form download a form for the first time or its updated version because it's a difference. If you download a form for...

> the icons themselves are actually Material yes, I meant refreshing buttons not just icons. > To me it looks very much like the Google Maps example is using Floating...

> How does that feel to you @grzesiek2010? Shape and size are great but I'm not sure if i like the color... (maybe I like just white more). What disabled...

> I couldn't think of a case where we disable them though? Maybe not in the map of forms but in geo widgets we do that: ![Screenshot_1654597579](https://user-images.githubusercontent.com/3276264/172358427-d4e9c8fb-5324-462c-b379-e93ba5a14768.png)

Yes the regression was introduced in v2022.2.0 so it's not a new thing. I could fix it but we also wanted to refactor that code https://github.com/getodk/collect/pull/5047 @seadowg what do you...

I can't reproduce the issue. There is also nothing bad in our implementation that we could improve. Since it's not new and we have only 2 affected users let's leave...

@dimwight My apologies for the delayed review! I would like to take a step back first and discuss that whole problem... I've never liked the fact that we needed to...

> Perhaps you could provide a further example that reworks my revised issue form so as to resolve the issues raised by @aurdipas? Yes, this should work well: [Entrevista_Nacimientos_Etnicos_filtro+.xlsx](https://github.com/getodk/collect/files/7801333/Entrevista_Nacimientos_Etnicos_filtro%2B.xlsx) I've...

@dimwight thanks for testing my solution. Let's wait for @lognaturel to see what she thinks.