grunweg

Results 112 comments of grunweg

Coming here for PR triage: is this PR still relevant? (Perhaps it is: we have the technical debt report, but that reports other statistics.) If it's relevant, what's missing to...

Thanks for the quick response. I was wondering about #guard_msg; good catch! Looking at the past logs, it seems #guard (in `test/vec_notation`) might also need to be allowed. From my...

Tests pass; I took one last look and pushed a few tiny tweaks. (@adomani Feel free to revert those if you prefer!) I think this lint is ready to go:...

Filed #13142 for the follow-up.

It's great to see the informal reviewing process that already happened, thanks a lot! In order for this PR to be merged, somebody with review powers still needs to give...

Actually, this PR is blocked on #11807 (and adapting it accordingly).

~~The CI failure is interesting: I have *no idea* where this is coming from. Help on this detail is welcome.~~ After rebasing, CI passes. I guess it was something intermittent.

Thanks for the review! I agree that making this list configurable could be useful - if somebody sees a specific use, I'm happy to look at PRs extending this!

I'm coming here for PR triage: it looks like this PR has fulfilled and can be closed. Is this correct?