grunweg

Results 112 comments of grunweg

There's a deeper issue underlying this: for any output line which overflows the terminal (i.e. is longer than the terminal width), we only increase the height by one --- even...

I just squashed changes and reworded the commit message. Basically, I think this fixes two bugs/defects: - the confirmation prompt should clear the entire rendering, not just the current line...

> the input prompt calls clear_line() right before calling clear() :-) I just pushed an additional commit which removes these now-superfluous calls.

Thanks for the trust :heart: That certainly sounds like an interesting small project; I'll see if/when I get to it. (This is a spare time project for me.)

I found some time to look into this today and just pushed a couple more commits with further doc improvements. Let me know if I you prefer me to squash...

I think I figured out what `prompt_reset_height` does. If prompts_reset_height is true, - `prompt_height` denotes the height (number of lines) of all input until the last prompt string. (If no...

Looking into the password prompt closely, I don't see how `prompts_reset_height=false` makes a difference for its execution. In interact_on, terminal output is produced the following ways: - prompt_password: produces "normal...

Setting `prompts_reset_heights=true` in the password prompt doesn't make a difference in practice. The distinction between self.height and self.prompt_height only matters when calling `TermThemeRenderer::clear_preserve_prompt()`: that method preserves prompts and only clears...

@mitsuhiko You introduced prompts_reset_height in 489a06572fe7204ff2a9dd4f82e5fe5dfd1ee8ef. Do you remember why you specifically set this to false for password prompts? I don't see a reason right now, but maybe I'm just...