Serhii Chvaliuk

Results 47 comments of Serhii Chvaliuk

> * is `ci_integration_workflow_launcher.sh` still needed, or can we delete it entirely? yes, I have removed > * seems like the goal of this PR is to add a single...

/test connector=connectors/source-amazon-ads > :clock2: connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2752904185 > :x: connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2752904185 > :bug: https://gradle.com/s/bxc35nkyv3gry > ### Build Failed Test summary info: ``` =========================== short test summary info ============================ FAILED test_core.py::TestBasicRead::test_read[inputs0] -...

/test connector=connectors/source-amazon-ads > :clock2: connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2755740785 > :x: connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2755740785 > :bug: https://gradle.com/s/aqiflyutcfrdo > ### Build Failed Test summary info: ``` =========================== short test summary info ============================ FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs1] ERROR...

/test connector=connectors/source-amazon-ads > :clock2: connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2756122726 > :white_check_mark: connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2756122726 Python tests coverage: ``` Name Stmts Miss Cover ------------------------------------------------------------------------ source_acceptance_test/utils/__init__.py 6 0 100% source_acceptance_test/tests/__init__.py 4 0 100% source_acceptance_test/__init__.py 2 0...

/test connector=connectors/source-amazon-ads > :clock2: connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2760246830 > :white_check_mark: connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2760246830 Python tests coverage: ``` Name Stmts Miss Cover ------------------------------------------------------------------------ source_acceptance_test/utils/__init__.py 6 0 100% source_acceptance_test/tests/__init__.py 4 0 100% source_acceptance_test/__init__.py 2 0...

in really it's good question I just pointed on inconsistency

As for me it can be any buffer size with some LRU mechanism. The main idea was - don't re-read data from upstream if it's already was read recenently as...

reading some simple articles about websocket I initially also thought that websocket library has to re-connect using some ping-pong heartbeat maybe re-implementing this Hearbeat class for receiving pings really good...