Ryan Grout

Results 100 comments of Ryan Grout
trafficstars

I'm glad I found this issue. This has been my question for the last couple of weeks. I'd been working on a solution to this when I came across this...

@sgillies I think you are conflating path-like with file-like. A path-like object represents a file path whereas a file-like object represents a file object (ie, with a .read() method). Path-like...

I suggest the following function be added to coords.py ```python def are_oriented(bounds1, bounds2): # should left/right also be checked? return ((bounds1[1] < bounds1[3] and bounds2[1] < bounds2[3]) or (bounds1[1] >...

@sgillies Do you have any thoughts on this? According to https://github.com/mapbox/rasterio/issues/525#issue-116584307, would `disjoint_bounds` need the transform to accurately interpret the sides of the bounding box (checking if y in the...

I'm not suggesting rewriting the test, though perhaps it should inspected to make sure it's a valid test. I'm pointing out that an existing test should cause disjoint_bounds to raise...

To succinctly summarize: A bounding box of (0, 10, 10, 0) and a bounding box of (0, 0, 10, 10) describe the same region of the Cartesian plane. To fix...

A comparison of existing and proposed solutions. ```python bound1 = BoundingBox(4.0, 4.0, 6.25, 6.25) bound2 = BoundingBox(0.0, 0.0, 10.0, 10.0) # Big box is not inverted disjoint_bounds(bound1, bound2) # False...

> The BoundingBox class is only a data class. I don't think we should add any new methods to it. I'm not suggesting that we add methods to BoundingBox. I...

I agree that an error should be raised if a bounding box is not well ordered. Perhaps BoundingBox should become similar to Window class where there is some validation upon...

> @groutr I disagree with the following statement. > > > A bounding box of (0, 10, 10, 0) and a bounding box of (0, 0, 10, 10) describe the...