Gilles Roudière
Gilles Roudière
I've updated the PR. I replaced anchors by "relative margins". It seems easier to understand IMO. I've also wrote the class's documentations.
> I really like this. While you can do mostly the same thing with just anchors, I think relative margins makes a lot more sense and would make UI work...
> The Margins should be called Offsets, don't repeat the same mistake 🙃 > Why is Custom preset clamped to 0-1? No, this is on purpose. I made this LayoutContainer...
> Well, we got feedback about Margins being confusing too, because they aren't really margins. E.g. on Center layout it becomes offset. No, not with this container at least. The...
> +1 that one should be called "Offsets." Especially considering that the 'extra margins' are linear, while the 'margins' are pixel sizes. Offsets are called "offsets" because they are always...
> In that case, could the linear margins be called 'relative margins' and pixel margins 'absolute margins'? Similar to CSS. Relative margins are already called that way (the properties are...
I do agree with @KoBeWi here, and I believe #87081 is a better solution to the problem as it supports rotation/skew too. However, if we want to keep a similar...
The main problem with that approach is that node gets sometimes removed then re-instantiated when a cell is updated in the same quadrant. So a variable storing a node might...
> @groud Oh! I actually thought the scene tiles re-instancing themselves whenever another is created nearby was a bug because it has been reported a few times since Feb and...
I think this is a step in the right direction, the only thing I dislike the idea of grouping things by "type" of GUI element. I don't think dialogs should...