Torsten Grote

Results 626 comments of Torsten Grote

> @grote this seems to be the solution for the locale selector imo. Can you please point me to the test case(s) that fail for our implementation? Due to the...

> [This](https://gitlab.com/fdroid/fdroidclient/-/blob/master/libs/index/src/androidAndroidTest/kotlin/org/fdroid/BestLocaleTest.kt#L44) is one of the test which fails with the current implementation of [LocaleChooser](https://gitlab.com/fdroid/fdroidclient/-/blob/master/libs/index/src/androidMain/kotlin/org/fdroid/LocaleChooser.kt#L8) This test seems to be copied one-to-one from F-Droid's source code (again without attribution and...

What device do you run it on? Which Android version? Maybe there's differences on older versions.

This is an instrumentation test. It won't work as a unit test which probably explains the failure you've been seeing. Roboelectric most likely doesn't provide the real implementation and just...

does it work when using the same ktor library version?

Does it work when excluding the ktor dependency from fdroid's downloader lib? is your kotlin-reflect dependency on the same kotlin version as your project?

Your stacktrace shows that you *do* use kotlin-reflect, so please as a first thing add it as an explicit dependency and ensure that it uses the same kotlin version as...

Looks like this MR is not taking into account changes to the ability to schedule exact alarms: https://developer.android.com/reference/android/app/AlarmManager#setExactAndAllowWhileIdle(int,%20long,%20android.app.PendingIntent) > Note: Starting with Build.VERSION_CODES#S, apps targeting SDK level 31 or higher...

Thanks @compressed! I can confirm that your workaround solves the problem of the page jumping to the top after it has been loaded fully.

No, I think the way this works is that new install use the version with the developer signature, so they are compatible with other releases. However, existing users upgrade with...