Michael Grosser

Results 470 comments of Michael Grosser

what is the error ?

try `kubectl get pods` or similar with the config file to make sure it actually works

yeah samson does not support that syntax ... as per https://github.com/abonas/kubeclient/issues/397 (kubeclient is what samson uses to talk to kubernetes) "use the --token option and also --api-server" ... I guess...

I'm fine with simply removing it ... it seems kinda noisy to do notifications for staging deploys anyway, that's why we never saw this problem :)

See .env.example for all github related settings https://github.com/zendesk/samson/blob/master/.env.example#L17-L19 There atm is no 'signup via email/password' if that is what you are asking. Usually everyone has a github account, so that...

we are already using the deployment API, but atm it only works for open PRs chatted with github and they don't want to help ... so would have to implement...

only thing we need is a new flag for this "opt-in" feature and then same logic to find the last commit in the PR if it's already merged ... we...

the deployment is created when opting in to the github plugin, the issue discussed here is that the deployment does not show on the merged PR since the deployment is...

The issue is that the deployed commit is not part of the PR Using squasch merges might make it work ... Otherwise the only option I can imagine is finding...