Fabian Groffen

Results 267 comments of Fabian Groffen

beware that most likely the best we can implement is that it show the picture of whatever was playing at the time the client first asked for the picture once...

idle player perhaps would cause the art to be re-retrieved, as [the description](https://mpd.readthedocs.io/en/latest/protocol.html#id14) says: player: the player has been started, stopped or seeked or tags of the currently playing song...

Just to make sure, this PR isn't good as it is, because it needs to return the binary data in chunks. It currently sends one giant chunk, but it should...

this is better done using https://github.com/grobian/owntone-server/commit/c2b439ad46e499509e81d1616af3904f87f1a00d and https://github.com/grobian/owntone-server/commit/ab79a20e08cef64e60d732092bb754d8458f951e

Hi @zmedico os.getloadavg() returns data everywhere I tried. Should it be unavailable, I think we should just ignore it, and disable or bark or something when load average limits are...

hmm, thanks for your report, what regex library do you use? (`carbon-c-relay -v` will tell)

Confirmed the behaviour with oniguruma.

I see the problem, the replacement contains no expansions, which causes a different/faster, but inconsitent/incorrect path.

`host\.b[0-9]+\.component1\.c.*` != `host\.b[0-9]+\.component1\.c` I think what you're looking for is `^host\.b[0-9]+\.component1\.c.*$` The regex match is applied to the entire metric, as the regex is defined, it returns the position inside...