Grisha Kruglov
Grisha Kruglov
FWIW, I had to switch to using Focus full-time since the browser is unusable to me right now (i usually use the awesomebar to navigate, so it's pretty frustrating). Can't...
I'm going to ensure that we're doing the correct thing in Fenix - e.g. never running this code on the main scope.
Nowadays, `places::run_maintenance` does the following: ``` conn.execute_all(&[ "VACUUM", "PRAGMA optimize", "PRAGMA wal_checkpoint(PASSIVE)", ])?; ``` For larger databases, VACUUM-ing could be quite expensive both in terms of IO and free disk...
Also, when this call was enabled, we got the following crashes: https://sentry.prod.mozaws.net/operations/firefox-nightly/issues/6463190/events/71639081/ - `Error executing SQL: UNIQUE constraint failed: moz_places.id`. This is probably happening during a VAACUM... but maybe possible...
We already have a "prune history metadata" call - https://github.com/mozilla-mobile/fenix/blob/main/app/src/main/java/org/mozilla/fenix/components/Core.kt#L253. But it doesn't seem like we call `pruneDestructively` for history itself.
@piquadrat you might still want to put a note about aldryn-search into the README of the project. It might save people some time digging around :+1: